Skip to content

[Datafactory] Adding additionProperties to allow serializing/deserializing new properties as JSON extension data#2033

Merged
sergey-shandar merged 2 commits intoAzure:currentfrom
hvermis:current
Nov 21, 2017
Merged

[Datafactory] Adding additionProperties to allow serializing/deserializing new properties as JSON extension data#2033
sergey-shandar merged 2 commits intoAzure:currentfrom
hvermis:current

Conversation

@hvermis
Copy link
Contributor

@hvermis hvermis commented Nov 20, 2017 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

azuresdkciprbot commented Nov 21, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkci azuresdkci assigned sergey-shandar and unassigned alvadb Nov 21, 2017
@azuresdkciprbot
Copy link

azuresdkciprbot commented Nov 21, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/datafactory/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

sergey-shandar
sergey-shandar suggested changes Nov 21, 2017
View reviewed changes
Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvermis please, fix examples according to new changes. See examples validation errors here https://travis-ci.org/Azure/azure-rest-api-specs/jobs/305486006. The PR contains SDK breaking changes.

@hvermis
Copy link
Contributor Author

hvermis commented Nov 21, 2017

Opened an issue to track fixing the examples:
#2038

@sergey-shandar sergey-shandar merged commit 081f4ac into Azure:current Nov 21, 2017
@AutorestCI
Copy link

AutorestCI commented Nov 21, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI AutorestCI mentioned this pull request Nov 21, 2017
Closed
@AutorestCI
Copy link

AutorestCI commented Nov 21, 2017

Build Status Azure/azure-sdk-for-python#1640

This was referenced Nov 22, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

potential-sdk-breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hvermis @azuresdkciprbot @AutorestCI @sergey-shandar @azuresdkci @olydis @alvadb